Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Add Webhooks delete events with expanded schemas #5519

Merged
merged 3 commits into from
Sep 20, 2024
Merged

[IMPROVEMENT] Add Webhooks delete events with expanded schemas #5519

merged 3 commits into from
Sep 20, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Sep 19, 2024 •
edited
Loading

Description

Added some changes so we can generate Webhook events before deleting resources and notify those events only after the resource has been successfully deleted.

Affected events:

  • Delete a dataset.
  • Delete a response.
  • Delete a record.
  • Delete many records.

Refs #1836

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

  • Manually test that deleted resource events are correctly working.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (a65eb96) to head (d4326bb).
Report is 21 commits behind head on feat/add-webhooks-feature-branch.

Additional details and impacted files 
@@                         Coverage Diff                          @@
##           feat/add-webhooks-feature-branch    #5519      +/-   ##
====================================================================
+ Coverage                             91.52%   91.57%   +0.05%     
====================================================================
  Files                                   158      159       +1     
  Lines                                  6345     6373      +28     
====================================================================
+ Hits                                   5807     5836      +29     
+ Misses                                  538      537       -1
Flag Coverage Δ
argilla-server 91.57% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo changed the title [DRAFT] [IMPROVEMENT] Add Webhooks delete events with expanded schemas [IMPROVEMENT] Add Webhooks delete events with expanded schemas Sep 20, 2024
@jfcalvo jfcalvo marked this pull request as ready for review September 20, 2024 10:49
@jfcalvo jfcalvo merged commit 6cd08fe into feat/add-webhooks-feature-branch Sep 20, 2024
6 checks passed
@jfcalvo jfcalvo deleted the improvement/add-webhooks-delete-events-with-expanded-schemas branch September 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfcalvo @frascuchon